18 replies to this topic

[SimDing0]

Okay, DLTCEP's variable scan brings up occurances of a variable only being referenced once.

Variable GLOBALkeldornleaves is referenced only 1 times.
Variable GLOBALteolmessanger is referenced only 1 times.
Variable GLOBALtickettaker is referenced only 1 times.
Variable GLOBALamtempleplottimer is referenced only 1 times.
Variable LOCALSfirestorm is referenced only 1 times.
Variable GLOBALjoinedlathander is referenced only 1 times.
Variable GLOBALcowledhq is referenced only 1 times.
Variable GLOBALderillichtimer is referenced only 1 times.
Variable GLOBALtalkedtoellie is referenced only 1 times.
Variable LOCALSnumberoftalk is referenced only 1 times.
Variable LOCALSreturnedspiderbane is referenced only 1 times.
Variable GLOBALhurgold is referenced only 1 times.
Variable GLOBALbanditenemy is referenced only 1 times.
Variable LOCALSfearsymbol is referenced only 1 times.
Variable GLOBALkeldornguildwilliam is referenced only 1 times.
Variable GLOBALch3reinit is referenced only 1 times.
Variable LOCALSarledhostile is referenced only 1 times.
Variable GLOBALcolettedaarhostile is referenced only 1 times.
Variable LOCALScamitisrun is referenced only 1 times.
Variable GLOBALscrollstudy is referenced only 1 times.
Variable GLOBALfarajileave is referenced only 1 times.
Variable GLOBALthreateneddaleson is referenced only 1 times.
Variable GLOBALtethtoriltalk is referenced only 1 times.
Variable LOCALSspawnimp is referenced only 1 times.
Variable GLOBALmelissanjail is referenced only 1 times.
Variable GLOBALfollowanomen is referenced only 1 times.
Variable GLOBALknowaboutkey is referenced only 1 times.
Variable GLOBALulraunt is referenced only 1 times.
Variable GLOBALpostul1nalia is referenced only 1 times.
Variable LOCALSpitfire is referenced only 1 times.
Variable GLOBALsecretopenar1611 is referenced only 1 times.
Variable GLOBALbaresh is referenced only 1 times.
Variable GLOBALrilmispawn is referenced only 1 times.
Variable LOCALSbloodpipe is referenced only 1 times.
Variable GLOBALwarning is referenced only 1 times.
Variable GLOBALtiirospawn is referenced only 1 times.
Variable GLOBALamnish2 is referenced only 1 times.
Variable GLOBALhelpeddrizzt is referenced only 1 times.
Variable GLOBALpartyarrest is referenced only 1 times.
Variable GLOBALtalkedtodaleson is referenced only 1 times.
Variable GLOBALwizardjob is referenced only 1 times.
Variable GLOBALladyspokenalia is referenced only 1 times.
Variable LOCALSenteredar1300 is referenced only 1 times.
Variable GLOBALsewage is referenced only 1 times.
Variable LOCALSimplosion is referenced only 1 times.
Variable GLOBALdeactivatetran3024 is referenced only 1 times.
Variable GLOBALriftdevicereturned is referenced only 1 times.
Variable GLOBALdeactivatetran3025 is referenced only 1 times.
Variable GLOBALhelplaurel is referenced only 1 times.
Variable GLOBALdeactivatetran3026 is referenced only 1 times.
Variable GLOBALarledhostile is referenced only 1 times.
Variable LOCALSfatherraised is referenced only 1 times.
Variable LOCALSescapevittorio is referenced only 1 times.
Variable GLOBALdestroyctrypt is referenced only 1 times.
Variable GLOBALprisonbreak is referenced only 1 times.
Variable LOCALStheduel is referenced only 1 times.
Variable GLOBALkaylalreadytalked is referenced only 1 times.
Variable LOCALSenteredwaukeen is referenced only 1 times.
Variable GLOBALnopayment is referenced only 1 times.
Variable LOCALSinlost is referenced only 1 times.
Variable GLOBALheardofslavelords is referenced only 1 times.
Variable GLOBALillaserahostile is referenced only 1 times.
Variable GLOBALfoughttazok is referenced only 1 times.
Variable GLOBALsaradushinsulttimer is referenced only 1 times.
Variable GLOBALsendaifinalbattle is referenced only 1 times.
Variable GLOBALdrowtimephaere is referenced only 1 times.
Variable GLOBALmdtakenhsssquest is referenced only 1 times.
Variable GLOBALhadamulet is referenced only 1 times.
Variable LOCALSbulliesleaveelves is referenced only 1 times.
Variable GLOBALmarriage is referenced only 1 times.
Variable GLOBALkorshagbag is referenced only 1 times.
Variable GLOBALdeathspawn is referenced only 1 times.
Variable GLOBALpostul2nalia is referenced only 1 times.
Variable GLOBALtalkedtolieutenant is referenced only 1 times.
Variable LOCALSyagbershout is referenced only 1 times.
Variable GLOBALtalkedtoaldeth is referenced only 1 times.
Variable GLOBALzgormad1 is referenced only 1 times.
Variable GLOBALdave is referenced only 1 times.
Variable LOCALSaskeddelthyr3 is referenced only 1 times.
Variable GLOBALtalkedtowelther is referenced only 1 times.

Variable GLOBALtalkedtohervo is referenced only 1 times.
Variable GLOBALungershowneb is referenced only 1 times.

Edited by SimDing0, 20 January 2005 - 09:43 AM.

[CamDawg]

You may get different results after the script and dialogue fixes are done, though.

[NiGHTMARE]

Many of these look like Unfinished Business ™ .

[SimDing0]

I've worked through some of these. Fixes so far:

COPY_EXISTING ~keldo25p.dlg~ ~override~
REPLACE_TEXTUALLY ~SetGlobal("KickedOut","GLOBAL",0)~ ~SetGlobal("KickedOut","LOCALS",0)~
BUT_ONLY_IF_IT_CHANGES

COPY_EXISTING ~keldornp.dlg~ ~override~
REPLACE_TEXTUALLY ~SetGlobal("LadyMaria","LOCALS",5)~ ~SetGlobal("LadyMaria","GLOBAL",5)~

COPY_EXISTING ~uhmay01.dlg~ ~override~
REPLACE_TEXTUALLY ~"RangerProtector","LOCALS"~ ~"RangerProtector","GLOBAL"~

COPY_EXISTING ~BRANNEL.BCS~ ~override~
DECOMPILE_BCS_TO_BAF
REPLACE_TEXTUALLY ~Global("LathanPlot1","GLOBAL",1)~ ~Global("LathanPlot","GLOBAL",1)~
REPLACE_TEXTUALLY ~Global("LathanPlot2","GLOBAL",1)~ ~Global("LathanPlot","GLOBAL",2)~
COMPILE_BAF_TO_BCS

COPY_EXISTING ~shthdr01.cre~ ~override~
WRITE_ASCII 0x250 "BRANNEL"

COPY_EXISTING ~sardw01.bcs~ ~override~
DECOMPILE_BCS_TO_BAF
REPLACE_TEXTUALLY ~"SaradushAmbientInsults","GLOBAL"~ ~"SaradushAmbientInsults","AR5000"~
COMPILE_BAF_TO_BCS

COPY_EXISTING ~viconij.dlg~ ~override~
REPLACE_TEXTUALLY ~"ViconiaInUnderdark","GLOBAL"~ ~"ViconiaInUnderdark","AR2100"~

COPY_EXISTING ~ilyich.dlg~ ~override~
REPLACE_TEXTUALLY ~"Acorns","GLOBAL"~ ~"Acorns","AR0602"~

COPY_EXISTING ~bhoisig.dlg~ ~override~
DECOMPILE_DLG_TO_D
REPLACE_TEXTUALLY ~"OisigDecided","GLOBAL"~ ~"OisigDecided","LOCALS"~
COMPILE_D_TO_DLG

COPY_EXISTING ~aeriej.dlg~ ~override~
DECOMPILE_DLG_TO_D
REPLACE_TEXTUALLY ~"AerieInUnderdark","GLOBAL"~ ~"AerieInUnderdark","AR2100"~
COMPILE_D_TO_DLG

COPY_EXISTING ~haerdaj.dlg~ ~override~
DECOMPILE_DLG_TO_D
REPLACE_TEXTUALLY ~"FightingTheTroupe","AR0510"~ ~"FightingTheTroupe","GLOBAL"~
COMPILE_D_TO_DLG

COPY_EXISTING ~ctaltar.bcs~ ~override~
DECOMPILE_BCS_TO_BAF
REPLACE_TEXTUALLY ~"PortalOpen","GLOBAL"~ ~"PortalOpen","AR3001"~
COMPILE_BAF_TO_BCS

COPY_EXISTING ~mgappro2.dlg~ ~override~
DECOMPILE_DLG_TO_D
REPLACE_TEXTUALLY ~"DropWizRing","GLOBAL"~ ~"DropWizRing","AR0411"~
COMPILE_D_TO_DLG

Edited by SimDing0, 04 March 2005 - 03:11 AM.

[CamDawg]

Gah, missed your fixes for v2. I've added them locally for v3 and I'm going to start working through this list as my next project.

Found some additional variable issues (these may or may not be bugs):

• aerieq is used as both a LOCALS and GLOBAL
  
• AnomenLeaveAngry and AnomenLeavesAngry are both used
  
• faceon and faceone are both used
  
• MinscWitch is a LOCALS and GLOBAL

* Variable GLOBALkeldornleaves is referenced only 1 times.
LOCALS/GLOBAL mixup, plus an additional error of using KeldornLeave and KeldornLeaves. Without the "s" appears to be correct as it's used in subsequent dialogue triggers.

REPLACE_ACTION_TEXT_REGEXP ~keldor[jp]~"KeldornLeaves?","\(GLOBAL\)\|\(LOCALS\)"~ ~"KeldornLeave","GLOBAL"~

[SimDing0]

You might wanna regenerate the list rather than using mine above, since I've removed stuff I've already examined and dismissed, but I might not have checked thoroughly enough, so maybe I dismissed stuff that needed fixing. Dunno.

[icelus]

OK, I'm going to install a minty fresh install of SoA/ToB sans Baldurdash and try to sort some of these out.

One question--
@Sim: How did you generate that list, exactly? When I did a variable scan in DLTCEP, I got something like this:

Quote

Crippled variable name: GLOBALsprite_is_deadYSELF) (block #0:Dead(S:Name*)(81))
Crippled variable name: GLOBALsprite_is_deadYSELF) (block #1:Dead(S:Name*)(81))
Crippled variable name: GLOBALsprite_is_deadYSELF) (block #5:Dead(S:Name*)(81))
Crippled variable name: GLOBALsprite_is_deadYSELF) (block #7:Dead(S:Name*)(81))
Crippled variable name: GLOBALsprite_is_deadYSELF) (block #8:Dead(S:Name*)(81))
Crippled variable name: GLOBALsprite_is_deadYSELF) (block #23:Dead(S:Name*)(81))
Crippled variable name: GLOBALsprite_is_deadASTSEENBY(MYSELF)) (block #23:Dead(S:Name*)(81))

[SimDing0]

Install our fixpack first, then try.

[icelus]

Okey dokey. I've installed a fresh copy of SoA/ToB/ToB patch/Fixpack v2.

Here is the current list of errors.

GLOBAL illaseradead is referenced only 1 times.
GLOBAL egeissagfightplayer1 is referenced only 1 times.
GLOBAL pirateasylum is referenced only 1 times.
LOCALS sawkhalid is referenced only 1 times.
GLOBAL impsfled is referenced only 1 times.
GLOBAL romanceconflictstart is referenced only 1 times.
LOCALS killdrow is referenced only 1 times.
GLOBAL juggernautalive is referenced only 1 times.
GLOBAL udsoltimer is referenced only 1 times.
LOCALS pcyosh is referenced only 1 times.
GLOBAL janmove is referenced only 1 times.
GLOBAL ironthronemurder is referenced only 1 times.
LOCALS rangerprotector is referenced only 1 times.
GLOBAL metgith is referenced only 1 times.
GLOBAL kptaxes is referenced only 1 times.
GLOBAL attackedkeldornsfamily is referenced only 1 times.
GLOBAL palacured is referenced only 1 times.
GLOBAL narlensteal is referenced only 1 times.
GLOBAL nobledopple is referenced only 1 times.
LOCALS badmonkgone is referenced only 1 times.
GLOBAL druidadreturn is referenced only 1 times.
GLOBAL saradushambientinsults is referenced only 1 times.
GLOBAL korganseescrypt is referenced only 1 times.
LOCALS returntopositions is referenced only 1 times.
GLOBAL drowtimesol is referenced only 1 times.
LOCALS tourmove is referenced only 1 times.
GLOBAL keldornleaves is referenced only 1 times.
GLOBAL tickettaker is referenced only 1 times.
LOCALS jaheiramad2 is referenced only 1 times.
LOCALS jaheiramad3 is referenced only 1 times.
LOCALS firestorm is referenced only 1 times.
LOCALS yagareturntimer is referenced only 1 times.
GLOBAL meethiggin2 is referenced only 1 times.
GLOBAL meethiggin3 is referenced only 1 times.
GLOBAL meethiggin4 is referenced only 1 times.
GLOBAL meethiggin5 is referenced only 1 times.
GLOBAL meethiggin7 is referenced only 1 times.
GLOBAL meethiggin8 is referenced only 1 times.
GLOBAL closedemogorgontemple is referenced only 1 times.
GLOBAL mekrathmonsters is referenced only 1 times.
LOCALS dragonwell is referenced only 1 times.
GLOBAL grae is referenced only 1 times.
GLOBAL enteredarea5203 is referenced only 1 times.
GLOBAL endgame is referenced only 1 times.
GLOBAL fschallenge is referenced only 1 times.
GLOBAL mazzytold is referenced only 1 times.
LOCALS deathofbodhi is referenced only 1 times.
GLOBAL naliaisaeaplotdone is referenced only 1 times.
LOCALS fearsymbol is referenced only 1 times.
GLOBAL keldornguildwilliam is referenced only 1 times.
GLOBAL bodhidead is referenced only 1 times.
GLOBAL goodelfkill is referenced only 1 times.
LOCALS fight1 is referenced only 1 times.
GLOBAL anomensaerktimer is referenced only 1 times.
GLOBAL scrollstudy is referenced only 1 times.
GLOBAL mairynappear is referenced only 1 times.
GLOBAL flooded is referenced only 1 times.
LOCALS sendaihostile is referenced only 1 times.
GLOBAL followanomen is referenced only 1 times.
LOCALS jaheiranalia is referenced only 1 times.
GLOBAL yoshimotalkspc2 is referenced only 1 times.
LOCALS viconiamad1 is referenced only 1 times.
LOCALS viconiamad2 is referenced only 1 times.
LOCALS viconiamad3 is referenced only 1 times.
LOCALS disabledeathtrap is referenced only 1 times.
LOCALS mazzycomment is referenced only 1 times.
LOCALS bmazzy1 is referenced only 1 times.
LOCALS bmazzy3 is referenced only 1 times.
GLOBAL imtoosexyforthisbrus is referenced only 1 times.
LOCALS bmazzy6 is referenced only 1 times.
GLOBAL followedgarren is referenced only 1 times.
GLOBAL talkedtodaleson is referenced only 1 times.
GLOBAL paladead is referenced only 1 times.
GLOBAL knightsdead is referenced only 1 times.
GLOBAL bodhijob is referenced only 1 times.
GLOBAL muddyfootprints is referenced only 1 times.
LOCALS favoredcomes is referenced only 1 times.
GLOBAL udmind is referenced only 1 times.
LOCALS implosion is referenced only 1 times.
LOCALS hendakmove is referenced only 1 times.
GLOBAL helplaurel is referenced only 1 times.
GLOBAL yoshimotalkspc is referenced only 1 times.
GLOBAL teolmessenger is referenced only 1 times.
GLOBAL templeshout0902 is referenced only 1 times.
GLOBAL githtimer1 is referenced only 1 times.
LOCALS druidfight is referenced only 1 times.
LOCALS korgancomplain is referenced only 1 times.
GLOBAL nopayment is referenced only 1 times.
LOCALS dilipoly is referenced only 1 times.
LOCALS solardeathspell is referenced only 1 times.
GLOBAL cuttest is referenced only 1 times.
LOCALS pimdeaddialogue is referenced only 1 times.
GLOBAL anomencortimer is referenced only 1 times.
GLOBAL findshagbag is referenced only 1 times.
GLOBAL edwintold is referenced only 1 times.
GLOBAL belljar is referenced only 1 times.
GLOBAL saradushinsulttimer is referenced only 1 times.
GLOBAL spawnbrus is referenced only 1 times.
GLOBAL drowtimephaere is referenced only 1 times.
GLOBAL korganbook is referenced only 1 times.
LOCALS mgpotionmade is referenced only 1 times.
GLOBAL talkedtocult is referenced only 1 times.
GLOBAL marriage is referenced only 1 times.
GLOBAL searchironthrone is referenced only 1 times.
GLOBAL haerdalismove is referenced only 1 times.
GLOBAL goseeedwin is referenced only 1 times.
LOCALS dropwizring is referenced only 1 times.
LOCALS jaheiramazzy is referenced only 1 times.
LOCALS lichfightstart is referenced only 1 times.
GLOBAL talkedtomadulf is referenced only 1 times.
LOCALS hgnya01timer is referenced only 1 times.
LOCALS hgnya01reappears is referenced only 1 times.
LOCALS bkeldorn9 is referenced only 1 times.
LOCALS crowddisperse is referenced only 1 times.
LOCALS minister4 is referenced only 1 times.
LOCALS minsckeldorn3 is referenced only 1 times.
LOCALS sourcereactivate is referenced only 1 times.
GLOBAL shagbagescapedialogue is referenced only 1 times.
GLOBAL solamnicbuttplug is referenced only 1 times.
GLOBAL helpedgarren is referenced only 1 times.
GLOBAL sprite_is_deadgorf03 is referenced only 1 times.
LOCALS byoshimo1 is referenced only 1 times.
LOCALS byoshimo3 is referenced only 1 times.
GLOBAL defeatedjon is referenced only 1 times.
GLOBAL talkedtovithal is referenced only 1 times.
GLOBAL ogronassault is referenced only 1 times.
GLOBAL spawndanno is referenced only 1 times.
GLOBAL dannobeginspalaplot is referenced only 1 times.
GLOBAL valenappeartimer is referenced only 1 times.
LOCALS jaheiraaerie is referenced only 1 times.
GLOBAL dropwizring is referenced only 1 times.
LOCALS palainbed is referenced only 1 times.
LOCALS melissandeathspell is referenced only 1 times.
GLOBAL eltanpoison is referenced only 1 times.
GLOBAL eldothfight is referenced only 1 times.
LOCALS staffpipe is referenced only 1 times.
LOCALS dialoguenowait is referenced only 1 times.
GLOBAL killeddruids is referenced only 1 times.
GLOBAL unseeingeye is referenced only 1 times.
GLOBAL williamattacked is referenced only 1 times.
GLOBAL aerieinunderdark is referenced only 1 times.
LOCALS bnalia4 is referenced only 1 times.
LOCALS bnalia6 is referenced only 1 times.
LOCALS bnalia7 is referenced only 1 times.

Edited by icelus, 13 March 2005 - 12:25 PM.

[devSin]

Keeping in mind that I already fixed the most obvious cases from Sim's list (and I make other changes here), these are the only ones I could verify as potentially funky (grep -ir is your friend):

Quote

GLOBAL egeissagfightplayer1 is referenced only 1 times.
GLOBAL pirateasylum is referenced only 1 times.
GLOBAL udsoltimer is referenced only 1 times.
GLOBAL drowtimesol is referenced only 1 times.
GLOBAL tickettaker is referenced only 1 times.
LOCALS yagareturntimer is referenced only 1 times.
GLOBAL closedemogorgontemple is referenced only 1 times.
GLOBAL fschallenge is referenced only 1 times.
GLOBAL keldornguildwilliam is referenced only 1 times.
LOCALS fight1 is referenced only 1 times.
GLOBAL followanomen is referenced only 1 times.
GLOBAL knightsdead is referenced only 1 times.
LOCALS korgancomplain is referenced only 1 times.
GLOBAL nopayment is referenced only 1 times.
GLOBAL belljar is referenced only 1 times.
GLOBAL drowtimephaere is referenced only 1 times.
GLOBAL talkedtocult is referenced only 1 times.
LOCALS hgnya01timer is referenced only 1 times.
LOCALS minister4 is referenced only 1 times.
LOCALS staffpipe is referenced only 1 times.

Edited by icelus, 13 March 2005 - 07:52 PM.

[icelus]

I have no clue what "grep -ir" means, but I will take your word for it and only focus on that list.

[icelus]

The only entry for the variable PIRATEASYLUM is in ppdesh.dlg. It is tucked away in a long list of actions, but here are a few of them:

AddXPObject(Player5,38500)
AddXPObject(Player6,38500)
SetGlobal("PirateAsylum","GLOBAL",11)
SetGlobal("AsylumPlot","GLOBAL",11)
StartCutSceneMode()
StartCutScene("Cut41f")

Since the value is set to 11, I'm going to go out on a limb and say that it's a superfluous GLOBAL. They probably just meant to advance the AsylumPlot.

[icelus]

drowtimesol seems to be the same thing. It's only found in baldur.bcs:

SetGlobal("udSolTimerOn","GLOBAL",0)
SetGlobal("udPhaTimerOn","GLOBAL",0)
SetGlobal("DrowTimeSol","GLOBAL",1)
SetGlobal("ADrowTimerHasExpired","GLOBAL",1)

(that's just a snippet)

[icelus]

tickettaker is an interesting one. It's only set once in aerie.dlg:

IF ~~ THEN BEGIN 19 // from:
SAY #2257 /* ~Come... Come back and visit, then. Maybe you'll have need of me in the future and I could travel with you. I'd like that.~ */
IF ~~ THEN DO ~SetGlobal("AerieMove","GLOBAL",1)
SetGlobal("TicketTaker","GLOBAL",1)
~ EXIT
END

Dunno... maybe... dunno. Doesn't seem too important, though.

[icelus]

I cannot find any use of yagareturntimer as a LOCAL. I'm not sure where DLTCEP found it... :-\