Jump to content


Missing Sound Files: language inconsistency


3 replies to this topic

#1 Guest_Hurricane_*

Guest_Hurricane_*
  • Guests

Posted 08 August 2011 - 08:14 PM

The Missing Sound Files component of the Core Fixes adds a couple of sound files from BG1 that are not present in BG2 but are referenced by some resources. However, the 4 added files

shael_07.wav
shael_08.wav
shael_09.wav
shael_10.wav

are not just neutral sound effects but spoken words ("Die!" / "Stun!" / "Pain!" / "Fear!"), hence the sounds should differ according to the language used. Currently, the Fixpack simply does

COPY
	 ~bg2fixpack/copy/shael_07.wav~ ~override~ // missing sound files
	 ~bg2fixpack/copy/shael_08.wav~ ~override~ // missing sound files
	 ~bg2fixpack/copy/shael_09.wav~ ~override~ // missing sound files
	 ~bg2fixpack/copy/shael_10.wav~ ~override~ // missing sound files
But the provided sound files are the sounds extracted from an English version of BG1. Obviously, these sounds do not fit in with a version other than the English one, since the words heard in the provided sound files are English. To resolve this, the implementation of these 4 sound files must be made language-sensitive and we need the respective BG1 sound files from the other language versions. These could then be placed in the bg2fixpack\%language% folders and copied from there. I can provide the BG1 files for the German version: SHAEL_xy-German.rar
Could anyone alter the implementation of the missing SHAEL sounds to make it work this way?

#2 aVENGER_(RR)

aVENGER_(RR)

    Sneaksie!

  • Fixpackers
  • 1008 posts
  • Gender:Male

Posted 13 January 2012 - 06:11 AM

Confirmed. Here's the fix:

--- setup-bg2fixpack.tp2    2010-03-15 19:54:10.000000000 +0100
+++ setup-bg2fixpack.v10    2012-01-13 07:27:08.671875000 +0100
@@ -1977,10 +1977,6 @@
      ~bg2fixpack/copy/misc_04a.wav~ ~override~ // missing sound files
      ~bg2fixpack/copy/misc_06b.wav~ ~override~ // missing sound files
      ~bg2fixpack/copy/pre_p06.wav~  ~override~ // missing sound files
-     ~bg2fixpack/copy/shael_07.wav~ ~override~ // missing sound files
-     ~bg2fixpack/copy/shael_08.wav~ ~override~ // missing sound files
-     ~bg2fixpack/copy/shael_09.wav~ ~override~ // missing sound files
-     ~bg2fixpack/copy/shael_10.wav~ ~override~ // missing sound files
      ~bg2fixpack/copy/sppr203d.spl~ ~override~ // shell spell for chant
      ~bg2fixpack/copy/sppr203e.spl~ ~override~ // shell spell for chant   
      ~bg2fixpack/copy/spwi413a.spl~ ~override~ // otiluke spell shell; see also spcl415.spl, spcl415a.spl, spwi413.spl
@@ -2001,6 +1997,13 @@
 
 END
 
+ACTION_IF ("%LANGUAGE%" STRING_EQUAL_CASE "english") THEN BEGIN // these are English-only sounds (spoken lines)
+  COPY ~bg2fixpack/copy/shael_07.wav~ ~override~ // missing sound files
+       ~bg2fixpack/copy/shael_08.wav~ ~override~ // missing sound files
+       ~bg2fixpack/copy/shael_09.wav~ ~override~ // missing sound files
+       ~bg2fixpack/copy/shael_10.wav~ ~override~ // missing sound files
+END
+
 /////                                                  \\\\\
 ///// dialogue fixes                                   \\\\\
 /////                                                  \\\\\

Retired modder

Rogue Rebalancing - Author
aTweaks - Author
Wizard Slayer Rebalancing - Co-Author
BG2 Fixpack - Contributor

#3 devSin

devSin
  • Fixpackers
  • 3017 posts
  • Gender:Male

Posted 13 January 2012 - 06:56 PM

Seriously? Just remove the files.

If somebody really wants to call the Durlag's Tower death knight's power word spells, let them copy the dumb sounds themselves.

Just sayin'...

#4 Hurricane

Hurricane
  • Members
  • 67 posts
  • Gender:Male

Posted 15 January 2012 - 05:54 AM

It's good to see that this problem got solved after all, thank you. :)

Reviewing my initial proposal, I can say that I am okay with the way it is fixed now. The missing sounds will hardly ever be noticed, and it's not worth the effort of gathering all the audio files for the different languages. At least for English, they are there.

If somebody really wants to call the Durlag's Tower death knight's power word spells, let them copy the dumb sounds themselves.


Yes, BGT for instance does exactly that.



Reply to this topic



  


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users