Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

0

[Repaired] Coran's Hanali Flirts are not working in v18

Started by Kulyok, Feb 21 2011 10:10 AM

2 replies to this topic

#1 Kulyok

Members
4306 posts

Gender:Female
Location:Moscow, Russia

Posted 21 February 2011 - 10:10 AM

Okay, so: Coran Romance has a Hanali cycle, a number of flirts which start through a PID option. I've been one of their first testers when they came out, so they were definitely working in one of the previous versions.

However, not so now. The problem is here: the first flirt requires Global("X#CoranHanaliRune","GLOBAL",1), but this variable is not getting set to 1 anywhere(it gets incremented to 3, to 11 and so on, but not to 1 - never to 1). Probably adding SetGlobal("X#CoranHanaliRune","GLOBAL",1) to BG1NPC/pid/x#pcinit.d will fix the issue.

WAS:
+ ~!Global("P#CoranDisableFlirts","GLOBAL",1) GlobalGT("P#CoranLover","GLOBAL",0) Global("X#CoranHanali","GLOBAL",0)~ + @3200 DO ~SetGlobal("X#CoranHanali","GLOBAL",1) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",10)~ + X#CoHa1

LIKELY SHOULD BE:
+ ~!Global("P#CoranDisableFlirts","GLOBAL",1) GlobalGT("P#CoranLover","GLOBAL",0) Global("X#CoranHanali","GLOBAL",0)~ + @3200 DO ~SetGlobal("X#CoranHanali","GLOBAL",1) SetGlobal("X#CoranHanaliRune","GLOBAL",1) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",10)~ + X#CoHa1

This is one of the best parts of Coran romance(which is a wonderful romance in itself), and unfortunately, it hasn't been working for Coran's players for nearly a year and a half now, which isn't so good, so I'd really appreciate if it was fixed for the next version soon, just like Jaheira's BG2 portrait.

Edited by cmorgan, 17 September 2011 - 11:14 AM.

IWD NPC, Xan, Assassinations, Dungeon Crawl, Tiax, Coran, Xan BG1 Friendship
BG1 NPC, Romantic Encounters

#2 cmorgan

journeyman investigator

Gibberlings
6710 posts

Gender:Male
Location:Glencoe, IL, USA

Posted 22 February 2011 - 08:43 AM

Checking...

CoranHanaliRune

Quote

ie_checkfiles/bg1npc-v18/bg1npc/bg1npc_docs/bg1npcvarindex.htm
8780: <td>X#CoranHanaliRune</td>
8791: <td>X#CoranHanaliRuneFirst</td>

ie_checkfiles/bg1npc-v18/bg1npc/phase3/corom/baf/p#corand.baf
Global("X#CoranHanaliRuneFirst","GLOBAL",0)
Global("X#CoranHanaliRune","GLOBAL",1)
IncrementGlobal("X#CoranHanaliRuneFirst","GLOBAL",1)
Global("X#CoranHanaliRune","GLOBAL",4)
Global("X#CoranHanaliRune","GLOBAL",6)
Global("X#CoranHanaliRune","GLOBAL",8)
Global("X#CoranHanaliRune","GLOBAL",12)
Global("X#CoranHanaliRune","GLOBAL",14)
Global("X#CoranHanaliRune","GLOBAL",16)
IncrementGlobal("X#CoranHanaliRune","GLOBAL",1)

ie_checkfiles/bg1npc-v18/bg1npc/phase3/corom/baf/p#corom.baf
Global("X#CoranHanaliRune","GLOBAL",2)
IncrementGlobal("X#CoranHanaliRune","GLOBAL",1)
Global("X#CoranHanaliRune","GLOBAL",3)
Global("X#CoranHanaliRune","GLOBAL",10)
IncrementGlobal("X#CoranHanaliRune","GLOBAL",1)
Global("X#CoranHanaliRune","GLOBAL",11)

ie_checkfiles/bg1npc-v18/bg1npc/phase3/corom/dlg/p#ciflirt.d
510: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",1) Global("X#CoranHanaliRuneFirst","GLOBAL",1)~ THEN BEGIN X#CoHa2
516: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",2) RestParty()~ EXIT
520: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",3)~ X#CoHa3
533: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",4) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300)~ EXIT
538: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",4) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300)~ EXIT
543: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",4) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300)~ EXIT
547: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",5)~ THEN BEGIN X#CoHa4
552: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",6) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300) RestParty()~ EXIT
556: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",7)~ THEN BEGIN X#CoHa5
562: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",8) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300) RestParty()~ EXIT
566: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",9)~ THEN BEGIN X#CoHa6
570: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",10) SetGlobalTimer("X#CoranLonging","GLOBAL", THREE_DAYS) SetGlobal("P#CoranRomanceInactive","GLOBAL",1) RestParty()~ EXIT
574: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",11)~ THEN BEGIN X#CoHa7
577: IF ~AreaType(FOREST)~ THEN REPLY @192 DO ~SetGlobal("P#CoranRomanceInactive","GLOBAL",0) SetGlobal("X#CoranHanaliRune","GLOBAL",12) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300)~ GOTO X#CoHa6.2
578: IF ~!AreaType(FOREST)~ THEN REPLY @192 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",12) SetGlobal("P#CoranRomanceInactive","GLOBAL",0) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300)~ GOTO X#CoHa6.3
597: IF WEIGHT #-3 ~%BGT_VAR% Global("X#CoranHanaliRune","GLOBAL",13)~ THEN BEGIN X#CoHa8
600: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",14) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300) RestParty()~ EXIT
604: IF ~Global("X#CoranHanaliRune","GLOBAL",15)~ THEN BEGIN X#CoHa9
609: IF ~~ THEN DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",16) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",300) RestParty()~ EXIT
614: IF ~Global("X#CoranHanaliRune","GLOBAL",17)~ THEN BEGIN X#CoHa10
620: ++ @211 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.1
621: ++ @212 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.2
622: ++ @213 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.3
623: ++ @214 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.4
624: ++ @215 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.5
625: ++ @216 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.6
626: ++ @217 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",18)~ + X#CoHa10.7

ie_checkfiles/bg1npc-v18/bg1npc/phase3/pid/x#pcinit.d
11979: + ~Global("X#CoranHanaliRune","GLOBAL",10)~ + @3082 DO ~SetGlobal("X#CoranHanaliRune","GLOBAL",12)~ + X#CoHa6.1

X#CoranHanali"

Quote

ie_checkfiles/bg1npc-v18/bg1npc/phase3/corom/baf/p#corand.baf
Global("X#CoranHanali","GLOBAL",1)

ie_checkfiles/bg1npc-v18/bg1npc/phase3/pid/x#pcinit.d
+ ~!Global("P#CoranDisableFlirts","GLOBAL",1) GlobalGT("P#CoranLover","GLOBAL",0) Global("X#CoranHanali","GLOBAL",0)~ + @3200 DO ~SetGlobal("X#CoranHanali","GLOBAL",1) RealSetGlobalTimer("X#CoHanaliTime","GLOBAL",10)~ + X#CoHa1
+ ~!Global("P#CoranDisableFlirts","GLOBAL",1) GlobalGT("P#CoranLover","GLOBAL",0) Global("X#CoranHanali","GLOBAL",1)~ + @3201 DO ~SetGlobal("X#CoranHanali","GLOBAL",3)~ EXIT

Relevant script blocks, run in DreamScript, so at rest:

IF %BGT_VAR% 
RealGlobalTimerExpired("X#CoHanaliTime","GLOBAL")
RealGlobalTimerExpired("X#DreamTalk","GLOBAL")
Global("X#CoranHanaliRuneFirst","GLOBAL",0)
Global("X#CoranHanaliRune","GLOBAL",1)
InParty(Myself)
!StateCheck(Player1,CD_STATE_NOTVALID)
!StateCheck(Myself,CD_STATE_NOTVALID)
!AreaType(DUNGEON)
THEN
RESPONSE #100
RealSetGlobalTimer("X#DreamTalk","GLOBAL",180)
PlaySong(0)
PlaySound("corang")
IncrementGlobal("X#CoranHanaliRuneFirst","GLOBAL",1)
StartDialogueNoSet(Player1)
END

IF %BGT_VAR% 
RealGlobalTimerExpired("X#CoHanaliTime","GLOBAL")
RealGlobalTimerExpired("X#DreamTalk","GLOBAL")
InParty(Myself)
!StateCheck(Player1,CD_STATE_NOTVALID)
!StateCheck(Myself,CD_STATE_NOTVALID)
!AreaType(DUNGEON)
!Global("P#CoranRomanceInactive", "GLOBAL",1)
GlobalGT("P#CoranLover","GLOBAL",0)
Global("X#CoranHanali","GLOBAL",1)
OR(6)
Global("X#CoranHanaliRune","GLOBAL",4)
Global("X#CoranHanaliRune","GLOBAL",6)
Global("X#CoranHanaliRune","GLOBAL",8)
Global("X#CoranHanaliRune","GLOBAL",12)
Global("X#CoranHanaliRune","GLOBAL",14)
Global("X#CoranHanaliRune","GLOBAL",16)
THEN
RESPONSE #100
RealSetGlobalTimer("X#DreamTalk","GLOBAL",180)
PlaySong(0)
PlaySound("corang")
IncrementGlobal("X#CoranHanaliRune","GLOBAL",1)
StartDialogueNoSet(Player1)
END

Confirmed - there are no mis-matches between P# and X# values; "X#CoranHanaliRune","GLOBAL" is not set in anything I can find in-project in v18. None of the IncrementGlobal() calls address 0 to 1.

Simplest repair is as advised - add SetGlobal("X#CoranHanaliRune","GLOBAL",1) to PID, x#pcinit.d at line 12371.

Until the next version comes out, players in the Coran Romance wanting to see this sequence will need to manually set the variable with

CLUAConsole:SetGlobal("X#CoranHanaliRune","GLOBAL",1)

Edited by cmorgan, 22 February 2011 - 08:44 AM.

I love deadlines. I love the whooshing noise they make as they go by. - Douglas Adams