Jump to content


Photo

Several Garrick issues...


1 reply to this topic

#1 Galathée

Galathée
  • Members
  • 10 posts

Posted 24 March 2009 - 12:35 AM

I hope I'm not pointing out things that have been repeated over and over, but I just finished the French translation of Garrick's files and noticed a couple of coding issues...

Here they come ! I hope they're clear like that, as I'm not used to the proper way to refer to them...

1) In the Garrick's part of the pcinit.d file, the GarrickPID2.x scripts, while present, are never accessed :

+ ~RandomNum(8,1)~ + @3621 + GarrickPID1.1
+ ~RandomNum(8,2)~ + @3621 + GarrickPID1.2
+ ~RandomNum(8,3)~ + @3621 + GarrickPID1.3
+ ~RandomNum(8,4)~ + @3621 + GarrickPID1.4
+ ~RandomNum(8,5)~ + @3621 + GarrickPID1.5
+ ~RandomNum(8,6)~ + @3621 + GarrickPID1.6
+ ~RandomNum(8,7)~ + @3621 + GarrickPID1.7
+ ~RandomNum(8,8)~ + @3621 + GarrickPID1.8

+ ~RandomNum(8,1)~ + @3622 + GarrickPID1.1
+ ~RandomNum(8,2)~ + @3622 + GarrickPID1.2
+ ~RandomNum(8,3)~ + @3622 + GarrickPID1.3
+ ~RandomNum(8,4)~ + @3622 + GarrickPID1.4
+ ~RandomNum(8,5)~ + @3622 + GarrickPID1.5
+ ~RandomNum(8,6)~ + @3622 + GarrickPID1.6
+ ~RandomNum(8,7)~ + @3622 + GarrickPID1.7
+ ~RandomNum(8,8)~ + @3622 + GarrickPID1.8


I believe, considering its content, that the @3622 line should lead to those files instead of the GarrickPID1.1-1.8 ones.

2) Very small thing : in the pcinit.tra file, line @3684, there is a <SIRMADAM> variable that should be <SIRMAAM>, I believe.

3) Another little thing, in the file x#garar.d, the coding for line @21 is written as if spoken by Garrick, while it seems, considering what is said, that Quayle should be the one saying it.

== ~%GARRICK_JOINED%~ IF ~InParty("quayle") InMyArea("quayle") !StateCheck("quayle",CD_STATE_NOTVALID)~ THEN @21


And that's all ! :blush:

#2 cmorgan

cmorgan

    journeyman investigator

  • Gibberlings
  • 6908 posts
  • Gender:Male
  • Location:Glencoe, IL, USA

Posted 24 March 2009 - 06:01 AM

Awesome reporting - I am establishing the next development version. I can confirm all three of these.


Repaired, v18_prerelease
\bg1npc_18_prerelease\phase3\pid\x#pcinit.d
IF ~IsGabber(Player1) %BGT_VAR%~ THEN BEGIN GACH
	SAY @3614
	++ @3615 EXIT
	+ ~Global("X#GACHdone","GLOBAL",1) RandomNum(4,1)~ + @3616 + GACHFailure1
	+ ~Global("X#GACHdone","GLOBAL",1) RandomNum(4,2)~ + @3616 + GACHFailure2
	+ ~Global("X#GACHdone","GLOBAL",1) RandomNum(4,3)~ + @3616 + GACHFailure3
	+ ~Global("X#GACHdone","GLOBAL",1) RandomNum(4,4)~ + @3616 + GACHFailure4
	+ ~!Global("X#GACHdone","GLOBAL",1) RandomNum(5,1)~ + @3617 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) RandomNum(5,2)~ + @3617 + GACHFailure1
	+ ~!Global("X#GACHdone","GLOBAL",1) RandomNum(5,3)~ + @3617 + GACHFailure2
	+ ~!Global("X#GACHdone","GLOBAL",1) RandomNum(5,4)~ + @3617 + GACHFailure3
	+ ~!Global("X#GACHdone","GLOBAL",1) RandomNum(5,5)~ + @3617 + GACHFailure4
	+ ~!Global("X#GACHdone","GLOBAL",1) CheckStatGT(Player1,15,INT) RandomNum(2,1)~ + @3618 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) CheckStatGT(Player1,15,INT) RandomNum(2,2)~ + @3618 + GACHFailure1
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,INT) RandomNum(5,1)~ + @3618 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,INT) RandomNum(5,2)~ + @3618 + GACHFailure1
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,INT) RandomNum(5,3)~ + @3618 + GACHFailure2
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,INT) RandomNum(5,4)~ + @3618 + GACHFailure3
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,INT) RandomNum(5,5)~ + @3618 + GACHFailure4
	+ ~!Global("X#GACHdone","GLOBAL",1) CheckStatGT(Player1,15,WIS) RandomNum(2,1)~ + @3619 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) CheckStatGT(Player1,15,WIS) RandomNum(2,2)~ + @3619 + GACHFailure2
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,WIS) RandomNum(5,1)~ + @3619 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,WIS) RandomNum(5,2)~ + @3619 + GACHFailure1
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,WIS) RandomNum(5,3)~ + @3619 + GACHFailure2
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,WIS) RandomNum(5,4)~ + @3619 + GACHFailure3
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,WIS) RandomNum(5,5)~ + @3619 + GACHFailure4
	+ ~!Global("X#GACHdone","GLOBAL",1) CheckStatGT(Player1,15,CHR) RandomNum(2,1)~ + @3620 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) CheckStatGT(Player1,15,CHR) RandomNum(2,2)~ + @3620 + GACHFailure3
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,CHR) RandomNum(5,1)~ + @3620 + GACHSuccess
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,CHR) RandomNum(5,2)~ + @3620 + GACHFailure1
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,CHR) RandomNum(5,3)~ + @3620 + GACHFailure3
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,CHR) RandomNum(5,4)~ + @3620 + GACHFailure2
	+ ~!Global("X#GACHdone","GLOBAL",1) !CheckStatGT(Player1,15,CHR) RandomNum(5,5)~ + @3620 + GACHFailure4
	+ ~RandomNum(8,1)~ + @3621 + GarrickPID1.1
	+ ~RandomNum(8,2)~ + @3621 + GarrickPID1.2
	+ ~RandomNum(8,3)~ + @3621 + GarrickPID1.3
	+ ~RandomNum(8,4)~ + @3621 + GarrickPID1.4
	+ ~RandomNum(8,5)~ + @3621 + GarrickPID1.5
	+ ~RandomNum(8,6)~ + @3621 + GarrickPID1.6
	+ ~RandomNum(8,7)~ + @3621 + GarrickPID1.7
	+ ~RandomNum(8,8)~ + @3621 + GarrickPID1.8
	+ ~RandomNum(8,1)~ + @3622 + GarrickPID2.1
	+ ~RandomNum(8,2)~ + @3622 + GarrickPID2.2
	+ ~RandomNum(8,3)~ + @3622 + GarrickPID2.3
	+ ~RandomNum(8,4)~ + @3622 + GarrickPID2.4
	+ ~RandomNum(8,5)~ + @3622 + GarrickPID2.5
	+ ~RandomNum(8,6)~ + @3622 + GarrickPID2.6
	+ ~RandomNum(8,7)~ + @3622 + GarrickPID2.7
	+ ~RandomNum(8,8)~ + @3622 + GarrickPID2.8
	++ @3623 + GarrickVoice
END

In bg1npc_18_prerelease\phase2\dlg\x#garar.d

CHAIN ~X#GARAR~ ArchGarri
@17
== ~%GARRICK_JOINED%~ @18
== ~X#GARAR~ @19
== ~%GARRICK_JOINED%~ @20
== ~%QUAYLE_JOINED%~ IF ~InParty("quayle") InMyArea("quayle") !StateCheck("quayle",CD_STATE_NOTVALID)~ THEN @21
== ~X#GARAR~ @22
== ~%EDWIN_JOINED%~ IF ~InParty("edwin") InMyArea("edwin") !StateCheck("edwin",CD_STATE_NOTVALID)~ THEN @23
== ~%GARRICK_JOINED%~ @24
END
IF ~~ THEN DO ~ActionOverride("archibald",GiveItem("X#GARBK",Player1)) SetGlobal("X#GarrickQuest","GLOBAL",1) SetGlobalTimer("X#GarrickBookTalkTimer","GLOBAL",10)~
EXIT

bg1npc_18_prerelease\tra\english\x#pcinit_tmp.tra
@3684 = ~Why, <SIRMAAM>, I would love to converse, but pressing matters await... ~

A check of the ClanDLAN materials shows they fixed this token during translation. I suspect it was reported, and slipped through my fingers :blush:. Searching all translation files in all directories for < to recheck all tokens again across the project.

(It will take some time to do that.)

For the eventual documentation,

<li> <a href="http://forums.gibberlings3.net/index.php?showtopic=17012&st=0&gopid=145893&#entry145893">Galathée's translation repairs to Garrick's dialog </a> </li>

I love deadlines. I love the whooshing noise they make as they go by. - Douglas Adams



Reply to this topic



  


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users