Jump to content


Photo

Small issue with v7


6 replies to this topic

#1 Wisp

Wisp
  • Modders
  • 972 posts
  • Gender:Male

Posted 04 January 2009 - 04:19 AM

Running a diff on the v7 tp2 I found this (line 18630 in the unmodified tp2):

WRITE_LONG  ("%fx_off%" + 0x08 + (0x30 * ("%abil_fx_idx%" + "%index2%" + 1))) 55  // icon: stun		SET "fx_delta" = ("%fx_delta%" + 2)
The fix is for the Barbarian Rage spell but as you can see, the fix will not correctly update effect indices since the update to fx_delta is commented out.
It will not matter to the vanilla Rage spell, since it only has 1 ability (so I'm not suggesting v7 should be updated because of this, so long as it makes it into v8 :().

Edited by Wisp, 04 January 2009 - 04:21 AM.


#2 Leomar

Leomar
  • Members
  • 405 posts
  • Location:Germany

Posted 07 January 2009 - 01:00 AM

If you can tell us, what and where we must fix, we can include a fix for that issue in the next Big World Fixpack.

Greetings Leomar

Edited by Leomar, 07 January 2009 - 01:00 AM.


#3 Salk

Salk
  • Members
  • 2355 posts
  • Gender:Male
  • Location:Sweden

Posted 07 January 2009 - 02:21 AM

I think - in my ignorance - that it's just a simple matter of moving

SET "fx_delta" = ("%fx_delta%" + 2)

in a line under since like it is now, it is commented out.

Edited by Salk, 07 January 2009 - 02:21 AM.


#4 Jarno Mikkola

Jarno Mikkola

    The Imp

  • Members
  • 3675 posts
  • Gender:Male
  • Location:The town where the dead haven't keeled over, yet. In Finland.

Posted 07 January 2009 - 05:16 AM

So that's
WRITE_LONG  ("%fx_off%" + 0x08 + (0x30 * ("%abil_fx_idx%" + "%index2%" + 1))) 55  // icon: stun

		SET "fx_delta" = ("%fx_delta%" + 2)
instead of a
WRITE_LONG  ("%fx_off%" + 0x08 + (0x30 * ("%abil_fx_idx%" + "%index2%" + 1))) 55  // icon: stun		SET "fx_delta" = ("%fx_delta%" + 2)
Copy/paste :( :(
Yes... I am probably still editing the post above.
FAQ for the Megamods. Frequently Answered Questions.

#5 DavidW

DavidW
  • Gibberlings
  • 4120 posts
  • Gender:Male

Posted 07 January 2009 - 09:45 AM

It probably depends how diligent you're feeling, though, Leomar: Wisp's quite right to point this out (& my bad, I think: copy/paste error), but it's only going to cause trouble in some fairly exotic circumstances.

#6 Leomar

Leomar
  • Members
  • 405 posts
  • Location:Germany

Posted 10 January 2009 - 12:10 AM

Thanks for the explanations. :D



I've a small issue with v7, too. A very small issue...

In the tp2 is a typo by the German translation.

LANGUAGE ~Deutsche (by Leonardo Watson)~		  ~german~  ~bg2fixpack/english/setup.tra~
Deutsche must be Deutsch (without an e).

It would be nice if you can correct this for the next release.

Greetings Leomar

#7 Nythrun

Nythrun

    Long since out to pasture

  • Modders
  • 1761 posts
  • Gender:Female

Posted 15 January 2010 - 03:54 PM

Added by DavidW for version 8.
"You tell lies, too."
"Not I." The witch laughed; her laughter was clear and yet unpleasant. "I used to as a child, I confess. But I soon found the truth more disconcerting."



Reply to this topic



  


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users