6 replies to this topic

[Wisp]

Running a diff on the v7 tp2 I found this (line 18630 in the unmodified tp2):

WRITE_LONG  ("%fx_off%" + 0x08 + (0x30 * ("%abil_fx_idx%" + "%index2%" + 1))) 55  // icon: stun		SET "fx_delta" = ("%fx_delta%" + 2)

The fix is for the Barbarian Rage spell but as you can see, the fix will not correctly update effect indices since the update to fx_delta is commented out.
It will not matter to the vanilla Rage spell, since it only has 1 ability (so I'm not suggesting v7 should be updated because of this, so long as it makes it into v8 ).

Edited by Wisp, 04 January 2009 - 04:21 AM.

[Leomar]

If you can tell us, what and where we must fix, we can include a fix for that issue in the next Big World Fixpack.

Greetings Leomar

Edited by Leomar, 07 January 2009 - 01:00 AM.

[Salk]

I think - in my ignorance - that it's just a simple matter of moving

SET "fx_delta" = ("%fx_delta%" + 2)

in a line under since like it is now, it is commented out.

Edited by Salk, 07 January 2009 - 02:21 AM.

[Jarno Mikkola]

So that's

WRITE_LONG  ("%fx_off%" + 0x08 + (0x30 * ("%abil_fx_idx%" + "%index2%" + 1))) 55  // icon: stun
		SET "fx_delta" = ("%fx_delta%" + 2)

instead of a

WRITE_LONG  ("%fx_off%" + 0x08 + (0x30 * ("%abil_fx_idx%" + "%index2%" + 1))) 55  // icon: stun		SET "fx_delta" = ("%fx_delta%" + 2)

Copy/paste

[DavidW]

It probably depends how diligent you're feeling, though, Leomar: Wisp's quite right to point this out (& my bad, I think: copy/paste error), but it's only going to cause trouble in some fairly exotic circumstances.

[Leomar]

Thanks for the explanations.



I've a small issue with v7, too. A very small issue...

In the tp2 is a typo by the German translation.

LANGUAGE ~Deutsche (by Leonardo Watson)~		  ~german~  ~bg2fixpack/english/setup.tra~

Deutsche must be Deutsch (without an e).

It would be nice if you can correct this for the next release.

Greetings Leomar

[Nythrun]

Added by DavidW for version 8.